Set pushed image tag using starlark flag #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimberezniker
approved these changes
Dec 5, 2022
deployment/BUILD
Outdated
| # container_push target can run at once. | ||
| string_flag( | ||
| name = "image_tag", | ||
| build_setting_default = "latest", |
There was a problem hiding this comment.
Should we set this to something like dev? The flag should generally be set and if something accidentally doesn't specify it, I don't think we should default to touching the latest tag.
There was a problem hiding this comment.
Done (used development instead of dev to avoid potential confusion with the dev environment)
tylerwilliams
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from setting the version with
--define=version=TAGto--//deployment:image_tag=TAG.Unfortunately the analysis cache is still discarded when changing starlark flags (see bazelbuild/bazel#13591), but I figured since the docs say that "--define" is "legacy syntax" it's worth migrating to a starlark flag either way.
Version bump: Patch